Skip to content

Conversation

dvora-ns
Copy link
Contributor

Closes #5266

📑 Description

The backend logs the following error while processing the request for /providers endpoint.

keep.providers.providers_factory: Could not get provider zabbix_provider methods. (2 validation errors for ProviderMethodParam
expected_values -> 0
str type expected (type=type_error.str)
expected_values -> 1
str type expected (type=type_error.str))

This occurs because change_severity method has a parameter of type Union[int, str] that the provider factory is not designed to handle. Hence, I have updated the parameter type to string and added validations to make sure the provided value is valid.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel
Copy link

vercel bot commented Aug 22, 2025

@dvora-ns is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dvora-ns dvora-ns marked this pull request as ready for review August 22, 2025 12:01
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working Provider Providers related issues labels Aug 22, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2025
@vercel
Copy link

vercel bot commented Aug 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
keep Ignored Ignored Preview Aug 23, 2025 9:04pm

@shahargl shahargl merged commit a920f1b into keephq:main Aug 23, 2025
19 checks passed
@github-actions
Copy link
Contributor

🎉 You're on fire, @dvora-ns! Three PRs merged and counting! 🔥🎉

Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖
Have you considered taking on some more challenging issues? We'd love to see what you can do! 💪

Remember, the team is always here to support you. Keep blazing that trail! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working lgtm This PR has been approved by a maintainer Provider Providers related issues size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: The /providers endpoint doesn't return zabbix provider methods

2 participants