fix: Pin urllib3 below version 2.4.0 that break back compatibility with older Kubernetes cluster CA on Python 3.13 #5239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der Kubernetes cluster CA on Python 3.13
|
@chafouin is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
size:XS
chafouin
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@chafouin can you dump version to |
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
Signed-off-by: Tal <tal@keephq.dev>
|
🚂 Well done @chafouin! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5224
📑 Description
Pin urllib3 below version 2.4.0, since this version introduced a breaking change with older Kubernetes cluster CA on Python 3.13, where certain fields are now required in the TLS certificates. Some Kubernetes clusters, especially old one, don't have those fields. Keep calls to the Kubernetes API will fail in those cases. In EKS case, it is unfortunately not possible to recreate the CA without recreating the whole cluster.
The Kubernetes Python library will put in place similar pinning, see kubernetes-client/python#2394.
✅ Checks
ℹ Additional Information