fix: time on filter #5238
Merged
fix: time on filter #5238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a time filtering bug in the search engine by changing the field used for time-based filtering from lastReceived to timestamp. The issue was that time_delta filtering in Keep Provider version 2 was using the wrong field, causing incorrect results when filtering alerts by time.
- Updated the search engine to use
timestampfield instead oflastReceivedfor time-based filtering - Added comprehensive test cases to verify the fix and prevent regression
- Version bump to reflect the bug fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| keep/searchengine/searchengine.py | Fixed the time filtering logic to use timestamp field instead of lastReceived |
| tests/test_search_alerts.py | Updated existing test expectations to reflect the corrected field usage |
| tests/test_keep_provider_time_delta.py | Added new comprehensive test cases to reproduce and verify the fix for the time filtering bug |
| pyproject.toml | Version bump from 0.46.4 to 0.46.5 |
talboren
previously approved these changes
Aug 5, 2025
Bugbot found 1 bugTo see it, have a team admin activate your membership in the Cursor dashboard. |
talboren
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5180