-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Adding speaker icon to a noisy alert #5223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meging latest changes
…ice-now-integration
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Feat/service now integration
feat/description regex and version upgrade
Signed-off-by: Shahar Glazner <shaharglazner@gmail.com>
Feat/add widget functionality
feat: Adding indicative speaker symbol to noisy alerts
Remove keep-ui/tsconfig.tsbuildinfo from repository
|
@DolevNe is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
dolevne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Username Password | 054a703 | keep_servicenow_0f2350e0a5a54b7d87ba5f1489649e0b | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closes #3229
📑 Description
I've added a speaker icon to "Noisy Alerts" (alerts that has "isNoisy = true" in their JSON), so if the alert is noisy and firing it will change the status icon to a speaker
✅ Checks