Skip to content

Conversation

@DolevNe
Copy link
Contributor

@DolevNe DolevNe commented Jul 28, 2025

Closes #3229

📑 Description

I've added a speaker icon to "Noisy Alerts" (alerts that has "isNoisy = true" in their JSON), so if the alert is noisy and firing it will change the status icon to a speaker

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
image image

dolevne and others added 30 commits February 12, 2025 14:54
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
feat/description regex and version upgrade
Signed-off-by: Shahar Glazner <shaharglazner@gmail.com>
@vercel
Copy link

vercel bot commented Jul 28, 2025

@DolevNe is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ DolevNe
✅ shahargl
❌ dolevne


dolevne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug Something isn't working UI User interface related issues labels Jul 28, 2025
@gitguardian
Copy link

gitguardian bot commented Jul 28, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Username Password 054a703 keep_servicenow_0f2350e0a5a54b7d87ba5f1489649e0b View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 28, 2025
@shahargl shahargl enabled auto-merge (squash) July 28, 2025 14:32
@vercel
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2025 2:44pm

@shahargl shahargl merged commit c71d7c0 into keephq:main Jul 28, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. UI User interface related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: noisy alert icon is missing

3 participants