-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Bringing back the OG Alerts Count Widget + Adding optional additional link functionality #5209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meging latest changes
…ice-now-integration
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Feat/service now integration
feat/description regex and version upgrade
Signed-off-by: Shahar Glazner <shaharglazner@gmail.com>
|
@DolevNe is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
dolevne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Username Password | 054a703 | keep_servicenow_0f2350e0a5a54b7d87ba5f1489649e0b | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: Shahar Glazner <shaharglazner@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Validation Message for Alert Count
The validation error message for the "Last alerts count to display" field (countOfLastAlerts) is incorrectly "Preset selection is required". It should state that the alert count is required, e.g., "Alert count is required".
keep-ui/app/(keep)/dashboard/widget-types/preset/preset-widget-form.tsx#L257-L259
keep/keep-ui/app/(keep)/dashboard/widget-types/preset/preset-widget-form.tsx
Lines 257 to 259 in 6cedcd6
| required: { | |
| value: true, | |
| message: "Preset selection is required", |
Bug: Invalid CSS Color Format in `hexToRgb` Function
The hexToRgb function generates an invalid CSS color format. When an alpha channel is provided, it incorrectly returns rgb(r, g, b, alpha) instead of the valid rgba(r, g, b, alpha), causing background styles to not render correctly with transparency.
keep-ui/app/(keep)/dashboard/widget-types/preset/widget-alert-count-panel.tsx#L120-L121
keep/keep-ui/app/(keep)/dashboard/widget-types/preset/widget-alert-count-panel.tsx
Lines 120 to 121 in 6cedcd6
| return `rgb(${r}, ${g}, ${b}, ${alpha})`; |
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
🏆 You're on fire, @DolevNe! Three PRs merged and counting! 🔥🎉 Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖 Remember, the team is always here to support you. Keep blazing that trail! 🚀 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes #5208
📑 Description
I've added the option to add a dashboard widget that shows count of preset alerts.
like the alerts table widget, but only a numeric value.
You can also choose to only show the firing alerts of the preset!
it changes the widget's color by the configured threshold
i've also added the option to configure an additional link to any service (Grafana Dashboard, Kibana etc.)
✅ Checks