Skip to content

Conversation

DolevNe
Copy link
Contributor

@DolevNe DolevNe commented Jul 21, 2025

Closes #5208

📑 Description

I've added the option to add a dashboard widget that shows count of preset alerts.
like the alerts table widget, but only a numeric value.
You can also choose to only show the firing alerts of the preset!
it changes the widget's color by the configured threshold
i've also added the option to configure an additional link to any service (Grafana Dashboard, Kibana etc.)

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
image image

dolevne and others added 30 commits February 12, 2025 14:54
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
Signed-off-by: DolevNe <130115929+DolevNe@users.noreply.github.com>
feat/description regex and version upgrade
Signed-off-by: Shahar Glazner <shaharglazner@gmail.com>
@vercel
Copy link

vercel bot commented Jul 21, 2025

@DolevNe is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ DolevNe
✅ shahargl
❌ dolevne


dolevne seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gitguardian
Copy link

gitguardian bot commented Jul 21, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Username Password 054a703 keep_servicenow_0f2350e0a5a54b7d87ba5f1489649e0b View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature A new feature UI User interface related issues labels Jul 21, 2025
cursor[bot]

This comment was marked as outdated.

Signed-off-by: Shahar Glazner <shaharglazner@gmail.com>
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 21, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Validation Message for Alert Count

The validation error message for the "Last alerts count to display" field (countOfLastAlerts) is incorrectly "Preset selection is required". It should state that the alert count is required, e.g., "Alert count is required".

keep-ui/app/(keep)/dashboard/widget-types/preset/preset-widget-form.tsx#L257-L259

required: {
value: true,
message: "Preset selection is required",

Fix in CursorFix in Web


Bug: Invalid CSS Color Format in `hexToRgb` Function

The hexToRgb function generates an invalid CSS color format. When an alpha channel is provided, it incorrectly returns rgb(r, g, b, alpha) instead of the valid rgba(r, g, b, alpha), causing background styles to not render correctly with transparency.

keep-ui/app/(keep)/dashboard/widget-types/preset/widget-alert-count-panel.tsx#L120-L121

return `rgb(${r}, ${g}, ${b}, ${alpha})`;

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@vercel
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 7:41am

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahargl shahargl merged commit 507b16e into keephq:main Jul 22, 2025
16 of 17 checks passed
@github-actions
Copy link
Contributor

🏆 You're on fire, @DolevNe! Three PRs merged and counting! 🔥🎉

Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖
Have you considered taking on some more challenging issues? We'd love to see what you can do! 💪

Remember, the team is always here to support you. Keep blazing that trail! 🚀

@sentry-io
Copy link

sentry-io bot commented Jul 22, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

@DolevNe DolevNe deleted the feat/add-widget-functionality branch July 27, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: return OG alerts widget and add functionality

4 participants