Skip to content

Conversation

@talboren
Copy link
Member

@talboren talboren commented Jul 9, 2025

close #4162

@vercel
Copy link

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2025 7:50am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Dependencies Pull requests that update a dependency file labels Jul 9, 2025
@talboren talboren changed the title feat: python 3.13 for security reasons chore(deps): python 3.13 for security reasons Jul 9, 2025
cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.73%. Comparing base (0026346) to head (a027ac4).
Report is 24 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5157       +/-   ##
===========================================
- Coverage   46.18%   30.73%   -15.46%     
===========================================
  Files         173      101       -72     
  Lines       17970    11493     -6477     
===========================================
- Hits         8299     3532     -4767     
+ Misses       9671     7961     -1710     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shahargl
shahargl previously approved these changes Jul 10, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 10, 2025
Signed-off-by: Tal <tal@keephq.dev>
cursor[bot]

This comment was marked as outdated.

Signed-off-by: Tal <tal@keephq.dev>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Property Access Error

The handleUpdateClick function now assumes the API response from PUT /providers/{id} will always contain a validatedScopes property. It directly accesses responseJson.validatedScopes without checking for its existence. If the API does not return this property, setProviderValidatedScopes will be called with undefined, potentially causing runtime errors or unexpected component behavior. This introduces an unhandled dependency on the API response structure.

keep-ui/app/(keep)/providers/provider-form.tsx#L414-L426

submit(`/providers/${provider.id}`, "PUT")
.then(
(responseJson: {
validatedScopes: { [key: string]: boolean | string };
}) => {
setIsLoading(false);
toast.success("Updated provider successfully", {
position: "top-left",
});
setProviderValidatedScopes(responseJson.validatedScopes);
mutate();
}
)

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talboren talboren merged commit b8b2044 into main Jul 13, 2025
22 of 25 checks passed
@talboren talboren deleted the feat/python3.13 branch July 13, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🔐 Security]: patch vulnerabilities in docker image

2 participants