-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(deps): python 3.13 for security reasons #5157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Tal <tal@keephq.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5157 +/- ##
===========================================
- Coverage 46.18% 30.73% -15.46%
===========================================
Files 173 101 -72
Lines 17970 11493 -6477
===========================================
- Hits 8299 3532 -4767
+ Misses 9671 7961 -1710 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Signed-off-by: Tal <tal@keephq.dev>
Signed-off-by: Tal <tal@keephq.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: API Response Property Access Error
The handleUpdateClick function now assumes the API response from PUT /providers/{id} will always contain a validatedScopes property. It directly accesses responseJson.validatedScopes without checking for its existence. If the API does not return this property, setProviderValidatedScopes will be called with undefined, potentially causing runtime errors or unexpected component behavior. This introduces an unhandled dependency on the API response structure.
keep-ui/app/(keep)/providers/provider-form.tsx#L414-L426
keep/keep-ui/app/(keep)/providers/provider-form.tsx
Lines 414 to 426 in a027ac4
| submit(`/providers/${provider.id}`, "PUT") | |
| .then( | |
| (responseJson: { | |
| validatedScopes: { [key: string]: boolean | string }; | |
| }) => { | |
| setIsLoading(false); | |
| toast.success("Updated provider successfully", { | |
| position: "top-left", | |
| }); | |
| setProviderValidatedScopes(responseJson.validatedScopes); | |
| mutate(); | |
| } | |
| ) |
Was this report helpful? Give feedback by reacting with 👍 or 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
close #4162