Skip to content

Conversation

@slgray
Copy link
Contributor

@slgray slgray commented Jul 3, 2025

Closes #5135

📑 Description

Zabbix 6.0.5 returns error responses like:

{
  "jsonrpc": "2.0",
  "error": {
    "code": -32602,
    "message": "Invalid params.",
    "data": "Incorrect arguments passed to function."
  },
  "id": 1234
}

for the event.acknowledge method. These errors are not caught by the original logic that only checks for "Invalid parameter". This commit broadens the error matching to also handle "Incorrect arguments", ensuring the endpoint accessibility validation works correctly across Zabbix versions.

Zabbix 6.0.5 returns error messages like 'Incorrect arguments passed to function.',
which are not caught by the original logic that only checks for 'Invalid parameter'.
This commit broadens the matching to ensure endpoint accessibility is still validated.

Signed-off-by: Slgray Chan <slgraychan@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jul 3, 2025

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Jul 3, 2025

@slgray is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Jul 3, 2025 0:24am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working labels Jul 3, 2025
@shahargl shahargl enabled auto-merge (squash) July 3, 2025 12:29
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.14%. Comparing base (0026346) to head (ea937cd).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5143      +/-   ##
==========================================
- Coverage   46.18%   46.14%   -0.05%     
==========================================
  Files         173      174       +1     
  Lines       17970    18045      +75     
==========================================
+ Hits         8299     8326      +27     
- Misses       9671     9719      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahargl shahargl merged commit 0bcaacd into keephq:main Jul 3, 2025
19 of 21 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

🎉 Fantastic work @slgray! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Error Connecting Zabbix Provider on Zabbix Version 6.0.5 – event.acknowledge Scope Fails with Invalid Arguments

3 participants