fix: History page makes keep unresponsive

[skynetigor]

…ays a new object every render

Closes #5126

📑 Description

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• All the tests have passed

ℹ Additional Information

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
keep	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2025 0:37am

[cursor]

Bug: Incomplete Dependency Array in useMemo

The useMemo for parsedLocalStorageValue has an incomplete dependency array. It uses initialValue (via initialValueRef.current) but only depends on localStorageValue. This causes stale values to be returned when initialValue changes and localStorageValue is null or empty, as getParsedJson falls back to initialValue and the memoized function does not re-run.

keep-ui/utils/hooks/useLocalStorage.ts#L37-L41

keep/keep-ui/utils/hooks/useLocalStorage.ts

Lines 37 to 41 in 56641c9

	);
	const initialValueRef = useRef(initialValue);
	initialValueRef.current = initialValue;
	const parsedLocalStorageValue = useMemo(() => getParsedJson(localStorageValue, initialValueRef.current), [localStorageValue]);

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[shahargl]

lgtm