Skip to content

Conversation

@skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Jul 2, 2025

Closes #5114

📑 Description

  • Fix the bug
  • Cover useAlertsTableData with unit-tests

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel
Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 1:13pm

@skynetigor skynetigor changed the title fix: Add parentheses for search cel being sent to BE to fix searcCel/facetFilterCel logic fix: Add parentheses for search cel being sent to BE to fix searcCel/facetFilterCel/dateRangeCel logic Jul 2, 2025
@skynetigor skynetigor marked this pull request as ready for review July 2, 2025 10:37
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Bug Something isn't working labels Jul 2, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

…eing always a new object every render"

This reverts commit 5602b7f.
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2025
@skynetigor skynetigor merged commit 04c9675 into main Jul 3, 2025
22 of 23 checks passed
@skynetigor skynetigor deleted the 5114-status-facet-bug branch July 3, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Facet Filters in Preset Do Not Apply Correctly (e.g., Status or Severity)

2 participants