fix: correlation rule threshold counts already resolved alerts #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:XL
🚨 BugBot couldn't runBugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_aee548f4-b3d0-4686-be70-42dc65d7690b). |
VladimirFilonov
force-pushed
the
fix/5115-bug-correlation-rule-threshold-counts-already-resolved-alerts
branch
from
863ab7b to
f020533
Compare
🚨 BugBot couldn't runBugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_d340d18c-ff81-495e-8bb0-8bf0125e33a0). |
Kiryous
previously approved these changes
Jul 1, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements a new unresolvedCounter system to fix correlation rule thresholds counting resolved alerts, ensuring incidents only trigger based on currently active alerts.
- Added
unresolvedCounterfield toAlertDtomodel inkeep/api/models/alert.pyto track unresolved alerts separately from totalfiringCounter - Modified
keep/rulesengine/rulesengine.pyto useunresolvedCounterinstead offiringCounterwhen evaluating incident thresholds - Added
calculated_unresolved_counterhelper inkeep/api/utils/enrichment_helpers.pythat resets to 0 when alerts are resolved - Added comprehensive test coverage in
tests/test_counting_integration.pyandtests/test_rules_engine.pyvalidating threshold behavior with grouped and same-fingerprint alerts
8 files reviewed, 7 comments
Edit PR Review Bot Settings | Greptile
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This commit introduces a new test to verify incident visibility and alert grouping behavior when thresholds are applied. It ensures incidents start automatically based on alert thresholds, validating grouping functionality and enrichment logic.
Introduce `unresolvedCounter` to track the number of unresolved alerts before resolution. Updated alert processing logic, added helper functions, and extended test coverage to ensure the counter increments/decrements as expected in various scenarios.
Updated a docstring to clarify the calculation of the unresolved counter in `enrichment_helpers.py`. Also adjusted import formatting in `process_event_task.py` for better readability.
Corrected the unresolved counter calculation and adjusted test cases to ensure accurate validation of resolved alert statuses. Updated comments and assertions to align with the clarified counter behavior.
VladimirFilonov
force-pushed
the
fix/5115-bug-correlation-rule-threshold-counts-already-resolved-alerts
branch
from
f20d388 to
a83758c
Compare
VladimirFilonov
deleted the
fix/5115-bug-correlation-rule-threshold-counts-already-resolved-alerts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5115
📑 Description
✅ Checks
ℹ Additional Information