Skip to content

Conversation

@00041275
Copy link
Contributor

close #4766

@vercel
Copy link

vercel bot commented Jun 30, 2025

@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. API API related issues Bug Something isn't working labels Jun 30, 2025
cursor[bot]

This comment was marked as outdated.

@00041275
Copy link
Contributor Author

keephq logic drawio

  1. get_alerts_by_fingerprint - replaced to function without enrich because it will change pulled alert hash
  2. process_event - added fingerprint for pulled alert
  3. __internal_prepartion - not decided (need your comment, may on alert create fingerprint can be null?)
  4. deduplication - add sort for dict json (it related for hash)

@00041275
Copy link
Contributor Author

@shahargl please check

cursor[bot]

This comment was marked as outdated.

@00041275 00041275 changed the title fix pull alerts fingerprint fix: pull alerts fingerprint Jul 6, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Variable Reference Causes NameError

The format_alert_fingerprint method incorrectly returns formatted_alert (singular), which is undefined, instead of the formatted_alerts (plural) parameter, leading to a NameError.

keep/providers/base/base_provider.py#L459-L460

)
return formatted_alert

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@shahargl
Copy link
Member

closing as stale, feel free to re-open @00041275

@shahargl shahargl closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API API related issues Bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: deduplication config ignored, mapping work after workflow

2 participants