fix: severity handling bug in CEL #5101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add preprocess_cel_expression import to workflowmanager.py - Apply severity preprocessing before CEL compilation to convert string comparisons like 'severity > "info"' to numeric comparisons - This fixes the bug where 'high' < 'info' lexicographically but high (4) > info (2) numerically - Add comprehensive tests for severity comparisons in workflows Fixes #5086
- Convert alert severity string values to numeric order before CEL evaluation - This ensures compatibility with preprocessed CEL expressions that convert severity comparisons like 'severity > "info"' to 'severity > 2' - Prevents TypeError when comparing StringType with IntType in CEL evaluation - Matches the approach used in rules engine for consistent behavior across the system This completes the fix for GitHub issue #5086 where severity comparisons in workflow CEL expressions were failing due to lexicographic vs numeric comparison.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5086
Fix CEL severity comparisons in workflows to use numeric values instead of lexicographic strings.
Previously, CEL expressions like
severity > 'info'were evaluated lexicographically (e.g., 'high' < 'info') and caused type errors when compared to preprocessed numeric values. This PR ensures both the CEL expression and the alert's severity value are converted to their numeric order (e.g., high (4) > info (2)) before evaluation, resolving incorrect filtering and type errors.