-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: generate and upload json schema #5088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
=======================================
Coverage 46.18% 46.18%
=======================================
Files 173 173
Lines 17970 17970
=======================================
Hits 8299 8299
Misses 9671 9671 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…hq/keep into feat/5087-workflow-yaml-json-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Schema Refactoring Breaks Post-Processing Callback
The postProcess callback in generateWorkflowYamlJsonSchema.ts, which enforces that a workflow must have either steps or actions, is not being applied. This is because the rootPath constant was updated to #/definitions/KeepWorkflowSchema/properties/workflow following a refactoring that changed the schema name from "WorkflowSchema". However, the postProcess callback's path comparison fails because refs.currentPath (the actual path generated by zod-to-json-schema for the workflow root) still reflects the old schema name or structure, preventing the necessary schema modifications.
keep-ui/entities/workflows/lib/generateWorkflowYamlJsonSchema.ts#L3-L5
| const schemaName = "KeepWorkflowSchema"; | |
| const rootPath = `#/definitions/${schemaName}/properties/workflow`; |
Was this report helpful? Give feedback by reacting with 👍 or 👎
This reverts commit f3e82ee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #5087
Summary
console_providernotify method to receive **kwargs to support enrich_incident param, updates e2e due to this change.