Skip to content

Conversation

@Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Jun 24, 2025

Closes #5087

Summary

  1. Adds a github workflow to publish JSON schema of Workflow YAML to keephq/workflow-json-schema.
  2. Makes e2e more robust, adding retry for selecting combobox options.
  3. Allows console_provider notify method to receive **kwargs to support enrich_incident param, updates e2e due to this change.

@vercel
Copy link

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jun 30, 2025 3:33pm

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.18%. Comparing base (0026346) to head (df92c1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5088   +/-   ##
=======================================
  Coverage   46.18%   46.18%           
=======================================
  Files         173      173           
  Lines       17970    17970           
=======================================
  Hits         8299     8299           
  Misses       9671     9671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kiryous Kiryous marked this pull request as ready for review June 27, 2025 09:47
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature A new feature labels Jun 27, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Schema Refactoring Breaks Post-Processing Callback

The postProcess callback in generateWorkflowYamlJsonSchema.ts, which enforces that a workflow must have either steps or actions, is not being applied. This is because the rootPath constant was updated to #/definitions/KeepWorkflowSchema/properties/workflow following a refactoring that changed the schema name from "WorkflowSchema". However, the postProcess callback's path comparison fails because refs.currentPath (the actual path generated by zod-to-json-schema for the workflow root) still reflects the old schema name or structure, preventing the necessary schema modifications.

keep-ui/entities/workflows/lib/generateWorkflowYamlJsonSchema.ts#L3-L5

const schemaName = "KeepWorkflowSchema";
const rootPath = `#/definitions/${schemaName}/properties/workflow`;

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

@Kiryous Kiryous requested a review from talboren June 30, 2025 09:04
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2025
@Kiryous Kiryous merged commit 32e0243 into main Jun 30, 2025
23 of 27 checks passed
@Kiryous Kiryous deleted the feat/5087-workflow-yaml-json-schema branch June 30, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[📃 Docs]: publish workflow json schema

2 participants