fix: db write secret error #5081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. method `install_providers` in providers_service.py need to use `provider_unique_id` as provider_id(currently use type) to save specific consumer provider to db and make sure when removing specific one instead of all consumers with same type. 2. method remove_consumer in event_subscriber.py wants `str` but given `object`: `provider_model`, will never take effective, need to send `provider_model.id`. 3. method `update_provider` in providers_service.py: need to re-add consumer to make sure configuration is latest in provider.. Signed-off-by: cheterchao <42969446+zcc0077@users.noreply.github.com>
Signed-off-by: cheterchao <42969446+zcc0077@users.noreply.github.com>
Signed-off-by: cheterchao <42969446+zcc0077@users.noreply.github.com>
This reverts commit 1e59259.
This reverts commit 2c65ec0.
(builtins.TypeError) SQLite DateTime type only accepts Python datetime and date objects as input. [SQL: UPDATE secret SET value=?, last_updated=? WHERE secret."key" = ?]
|
@zcc0077 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
size:S
dosubot
bot
added
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
🎉 Well done @zcc0077! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5080
📑 Description
fix write_secret error when update(e.g. update installed provider):
✅ Checks
ℹ Additional Information