Implement feature and add tests

[shahargl]

close #5070

GitHub issue %235070, concerning conditional namespace display in Teams Adaptive Cards, was addressed.

The root cause was identified in keep/iohandler/iohandler.py's render_context() method, where safe=True caused a RenderException for missing mustache template keys (e.g., {{ alert.labels.namespace }}).

To resolve this, three new tests were added to tests/test_teams_provider.py:

• test_github_issue_5070_mustache_template_rendering() to reproduce the issue.
• test_teams_adaptive_card_safe_rendering_patterns() to test the Teams provider with safe rendering.
• test_render_context_safe_parameter_handling() to validate IOHandler.render_context() behavior.

Two safe rendering patterns were documented and tested:

• keep.dictget({{ alert.labels }}, 'namespace', 'N/A') for robust default value handling.
• Mustache conditionals for more complex logic.

An example workflow, examples/workflows/teams-adaptive-cards-safe-rendering.yaml, was created to demonstrate these patterns. A documentation file GITHUB_ISSUE_5070_IMPLEMENTATION.md was also added. pyproject.toml and poetry.lock were not modified, adhering to specific constraints, ensuring compatibility with Python 3.11 . All tests pass.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
keep	⬜️ Ignored (Inspect)	Visit Preview		Jun 22, 2025 6:29am

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Implement feature and add tests". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[cursor]

Bug: Alert Template Rendering Errors

The workflow contains two template rendering issues:

1. The service field is incorrectly accessed as alert.service or directly from alert in both dictget and Mustache conditional expressions. It should be alert.labels.service to match typical alert data structures.
2. The keep.dictget function for the environment field uses {{ alert.environment }} as an unsafe default value. This can cause a rendering error if alert.environment is missing, defeating the purpose of safe rendering. A static string should be used instead.

examples/workflows/teams-adaptive-cards-safe-rendering.yaml#L39-L45

keep/examples/workflows/teams-adaptive-cards-safe-rendering.yaml

Lines 39 to 45 in 6a7c559

	"type": "TextBlock",
	"text": "**🌍 Environment**: keep.dictget({{ alert.labels }}, \"environment\", {{ alert.environment }})"
	},
	{
	"type": "TextBlock",
	"text": "**🏷️ Service**: keep.dictget({{ alert }}, \"service\", \"Unknown\")"
	},

examples/workflows/teams-adaptive-cards-safe-rendering.yaml#L77-L80

keep/examples/workflows/teams-adaptive-cards-safe-rendering.yaml

Lines 77 to 80 in 6a7c559

	{
	"type": "TextBlock",
	"text": "**🏷️ Service**: {{#alert.service}}{{ alert.service }}{{/alert.service}}{{^alert.service}}Unknown{{/alert.service}}"
	},

Fix in Cursor

---

Bug: Mustache Template Errors in Teams Rendering

The teams-safe-rendering-mustache-conditionals action contains two issues:

1. The fallback for the Environment field uses {{ alert.environment }}, which can still fail if alert.environment is undefined, undermining the safe rendering approach. A static string fallback should be used instead.
2. The Service field incorrectly references {{ alert.service }} instead of {{ alert.labels.service }}, which is inconsistent with how other label fields are accessed.

examples/workflows/teams-adaptive-cards-safe-rendering.yaml#L73-L79

keep/examples/workflows/teams-adaptive-cards-safe-rendering.yaml

Lines 73 to 79 in 6a7c559

	{
	"type": "TextBlock",
	"text": "**🌍 Environment**: {{#alert.labels.environment}}{{ alert.labels.environment }}{{/alert.labels.environment}}{{^alert.labels.environment}}{{ alert.environment }}{{/alert.labels.environment}}"
	},
	{
	"type": "TextBlock",
	"text": "**🏷️ Service**: {{#alert.service}}{{ alert.service }}{{/alert.service}}{{^alert.service}}Unknown{{/alert.service}}"

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[cursor]

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_3db1e77b-cb68-4b91-b124-740eaa19ecd4).

[anhtaw]

Hi @shahargl ,

Do you have an estimated release date for the fix related to GitHub issue #5071?
We're currently deploying Keep using Helm, so it would be helpful to know when this fix will be included in an official release.

Thank you very much for your support!

Best regards