Skip to content

Conversation

VladimirFilonov
Copy link
Contributor

@VladimirFilonov VladimirFilonov commented Jun 18, 2025

Introduced a condition to ensure workflows with is_test_run set to true are excluded from the query. This ensures only non-test workflows are processed while adhering to the existing limit per workflow.

Closes #5051

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2025 2:16pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working labels Jun 18, 2025
skynetigor
skynetigor previously approved these changes Jun 18, 2025
Copy link
Contributor

@skynetigor skynetigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Introduced a condition to ensure workflows with `is_test_run` set to true are excluded from the query. This ensures only non-test workflows are processed while adhering to the existing limit per workflow.
Ensure `get_all_workflows_with_last_execution` excludes test run executions. This verifies that only regular workflow executions are returned in the results.
@VladimirFilonov VladimirFilonov force-pushed the fix/5051-bug-executions-graph-at-workflow-dashboard-differs-from-graph-at-detail-page branch from 1309d8a to 5d8c3ea Compare June 18, 2025 14:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 18, 2025
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VladimirFilonov VladimirFilonov merged commit 0871d37 into main Jun 18, 2025
25 of 29 checks passed
@VladimirFilonov VladimirFilonov deleted the fix/5051-bug-executions-graph-at-workflow-dashboard-differs-from-graph-at-detail-page branch June 18, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Executions graph at workflow dashboard differs from graph at detail page

3 participants