fix: Fix bug on incidents pagination

[skynetigor]

Closes #5055

📑 Description

• Move toggle/selectOne/selectAll functions to store from Facet component
• Write unit-tests for toggle/selectOne/selectAll in store
• Fix pagination bug on incidents

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• All the tests have passed

ℹ Additional Information

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
keep	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2025 11:01am

[shahargl]

lgtm

[cursor]

Bug: Undefined Array Handling Causes Type Error

A TypeError occurs when currentState.facetOptions?.[facetId] is undefined because .map() is called directly on it before the || [] fallback can be applied. This affects the toggleFacetOption and selectAllFacetOptions functions. In toggleFacetOption, this specifically breaks the logic intended to select all options except the toggled one when a facet has no prior state, resulting in an empty selection instead. The fix requires ensuring currentState.facetOptions?.[facetId] is an array before .map() is called, e.g., (currentState.facetOptions?.[facetId] || []).

keep-ui/features/filter/store/create-facets-store.ts#L104-L110

keep/keep-ui/features/filter/store/create-facets-store.ts

Lines 104 to 110 in 32cd14f

	if (!facetsState[facetId]) {
	newFacetState = toFacetState(
	currentState.facetOptions?.[facetId]
	.map((option) => valueToString(option.value))
	.filter((optionStrValue) => optionStrValue !== strValue) || []
	);

keep-ui/features/filter/store/create-facets-store.ts#L160-L165

keep/keep-ui/features/filter/store/create-facets-store.ts

Lines 160 to 165 in 32cd14f

	...facetsState,
	[facetId]: toFacetState(
	currentState.facetOptions?.[facetId].map((option) =>
	valueToString(option.value)
	) || []
	),

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎