Skip to content

Conversation

@skynetigor
Copy link
Contributor

…L configuration

Closes #5053

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@vercel
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2025 8:00am

@skynetigor skynetigor marked this pull request as ready for review June 18, 2025 11:11
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature A new feature labels Jun 18, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow Upload Fails; Execution Counting Flaky

The test_run_interval_workflow is flawed: the "Upload" button is located but not clicked, preventing the workflow from being uploaded. Additionally, it incorrectly attempts to count workflow executions by asserting on multiple table rows with the workflow's name on the main workflows page, which only lists workflow definitions. This, combined with a strict 10-second wait expecting exactly 4-6 executions, introduces timing-based race conditions and flakiness due to startup delays, system load, and UI rendering.

tests/e2e_tests/test_end_to_end.py#L866-L876

)
page.get_by_role("button", name="Upload")
expect(page.get_by_text("1 workflow uploaded successfully")).to_be_visible()
page.wait_for_timeout(
10000
) # wait 10 seconds to let interval workflow run few times
page.reload()
rows = page.locator("table tr", has_text="Interval workflow")
expect(rows).not_to_have_count(0)
executions_count = rows.count()
assert executions_count >= 4 and executions_count <= 6

Fix in Cursor


Was this report helpful? Give feedback by reacting with πŸ‘ or πŸ‘Ž

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 18, 2025
@skynetigor skynetigor merged commit 1afcb8c into main Jun 18, 2025
17 checks passed
@skynetigor skynetigor deleted the add_e2e_test_for_interval_workflow branch June 18, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Add E2E sanity test for interval workflow

2 participants