test: foreach jumps to the end of workflow in UI Builder #5031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…each and conditions (cherry picked from commit e952987)
dosubot
bot
added
size:L
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed workflow step ordering in the UI Builder, specifically addressing an issue where steps after a foreach loop were incorrectly jumping above it during YAML conversion.
- Modified
keep-ui/entities/workflows/lib/parser.tsto use sequential processing via for...of loop instead of filter/map to preserve step order - Added special handling in withParams to prevent parsing of 'code' parameters for python-step providers
- Added test case in
keep-ui/entities/workflows/lib/__tests__/parser.test.tsverifying correct step ordering with foreach loops - Improved foreach step handling by skipping processing when stepOrAction is invalid
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4996