-
Notifications
You must be signed in to change notification settings - Fork 414
WIP - Add kcp_cluster_index_clusters_on_shard metric #3482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xrstf: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Namespace: "kcp", | ||
Subsystem: "cluster_index", | ||
Name: "clusters_on_shard", | ||
Help: "Number of known logicalclusters per shard.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespace: "kcp", | |
Subsystem: "cluster_index", | |
Name: "clusters_on_shard", | |
Help: "Number of known logicalclusters per shard.", | |
Namespace: "kcp", | |
Subsystem: "front_proxy", | |
Name: "indexed_clusters", | |
Help: "Number of logicalclusters indexed by kcp-front-proxy or embedded localproxy per shard.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I first had "front_proxy" in there, but since the metric is available also on shards (because the localproxy also uses an index), it felt very confusing to name the metric "kcp_front_proxy_something_something".
Summary
This PR adds a new metric to the cluster index that reports the number of known logicalclusters per shard.
What Type of PR Is This?
/kind feature
Release Notes