Skip to content

WIP - Add kcp_cluster_index_clusters_on_shard metric #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jul 11, 2025

Summary

This PR adds a new metric to the cluster index that reports the number of known logicalclusters per shard.

What Type of PR Is This?

/kind feature

Release Notes

Add new `kcp_cluster_index_clusters_on_shard` metric that contains the number of known logicalclusters per shard (metric has a `shard` label).

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jul 11, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xrstf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2025
@kcp-ci-bot
Copy link
Contributor

@xrstf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-shared 9df7cfc link true /test pull-kcp-test-e2e-shared
pull-kcp-test-e2e-sharded 9df7cfc link true /test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e-multiple-runs 9df7cfc link true /test pull-kcp-test-e2e-multiple-runs

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Comment on lines +29 to +32
Namespace: "kcp",
Subsystem: "cluster_index",
Name: "clusters_on_shard",
Help: "Number of known logicalclusters per shard.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Namespace: "kcp",
Subsystem: "cluster_index",
Name: "clusters_on_shard",
Help: "Number of known logicalclusters per shard.",
Namespace: "kcp",
Subsystem: "front_proxy",
Name: "indexed_clusters",
Help: "Number of logicalclusters indexed by kcp-front-proxy or embedded localproxy per shard.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first had "front_proxy" in there, but since the metric is available also on shards (because the localproxy also uses an index), it felt very confusing to name the metric "kcp_front_proxy_something_something".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants