Skip to content

add trusted publishers #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

add trusted publishers #599

merged 1 commit into from
May 23, 2025

Conversation

mensfeld
Copy link
Member

No description provided.

@mensfeld mensfeld requested review from nijikon and Copilot May 23, 2025 10:43
@mensfeld mensfeld self-assigned this May 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes local gem signing in favor of trusted publishers and adds a GitHub Actions workflow to publish the gem automatically.

  • Remove gem.cert_chain and signing key logic from the gemspec
  • Delete the local certificate file
  • Update the changelog to note the move to trusted publishers
  • Add a push.yml workflow to automatically release tagged versions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
rdkafka.gemspec Removed cert_chain and signing_key configuration
certs/cert.pem Deleted the local certificate file
CHANGELOG.md Added changelog entry for migrating to trusted publishers
.github/workflows/push.yml Introduced a new workflow to publish gems on tag pushes
Comments suppressed due to low confidence (1)

.github/workflows/push.yml:12

  • [nitpick] The job id push is very generic; renaming it to something like release-gem or publish would make its purpose clearer.
  push:

@mensfeld mensfeld merged commit 9dbd30b into main May 23, 2025
12 checks passed
@mensfeld mensfeld deleted the move-to-trusted-publishers branch May 23, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant