-
Notifications
You must be signed in to change notification settings - Fork 19
FEC-9696 subtitles positioning #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giladna
wants to merge
16
commits into
kaltura:master
Choose a base branch
from
giladna:FEC-9696
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9d3c301
subtitles pos first draft
giladna 27c179f
capital
giladna c483a4a
- Spelling change
GouravSna 55e49cb
fix spelling
giladna f36f925
fix values
giladna 9cdf5df
fix code review comments
giladna 81f1850
update
giladna 6529222
cont
giladna 7f9328f
add dependancies explanation
giladna 2bee02f
review fixes
giladna 570fd9e
review fixes
giladna c50dfac
Review changes for change meida
giladna 4828897
typo
giladna 927af49
Update ads-android.md
8c94044
Merge branch 'master' into FEC-9696
giladna 066fe95
pass spelling check
giladna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.