-
-
Notifications
You must be signed in to change notification settings - Fork 151
BE: SR: Add compatibility w/ GCP SR #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
magnusdriver
wants to merge
6
commits into
kafbat:main
Choose a base branch
from
magnusdriver:feat/add-gcp-schema-registry-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e9d5a7d
Add all changes to connect with GCP Schema Registries
magnusdriver 5392e77
Expose BEARER_AUTH_CUSTOM_PROVIDER_CLASS parameter in config
magnusdriver 0726114
Clean code
magnusdriver aaa04b6
Clean code
magnusdriver 6ba0bc8
Move gcp tokens logic out of WebClientConfigurator
magnusdriver f2e8a53
Add new schema compatibilityConfigGCP
magnusdriver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
api/src/main/java/io/kafbat/ui/util/gcp/GcpBearerAuthFilter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package io.kafbat.ui.util.gcp; | ||
|
||
import com.google.cloud.hosted.kafka.auth.GcpBearerAuthCredentialProvider; | ||
import org.jetbrains.annotations.NotNull; | ||
import org.springframework.web.reactive.function.client.ClientRequest; | ||
import org.springframework.web.reactive.function.client.ClientResponse; | ||
import org.springframework.web.reactive.function.client.ExchangeFilterFunction; | ||
import org.springframework.web.reactive.function.client.ExchangeFunction; | ||
import reactor.core.publisher.Mono; | ||
|
||
public class GcpBearerAuthFilter implements ExchangeFilterFunction { | ||
|
||
private static final String GCP_BEARER_AUTH_CUSTOM_PROVIDER_CLASS = | ||
GcpBearerAuthCredentialProvider.class.getName(); | ||
|
||
private final GcpBearerAuthCredentialProvider credentialProvider; | ||
|
||
public GcpBearerAuthFilter() { | ||
this.credentialProvider = new GcpBearerAuthCredentialProvider(); | ||
} | ||
|
||
@NotNull | ||
@Override | ||
public Mono<ClientResponse> filter(ClientRequest request, ExchangeFunction next) { | ||
// This Mono ensures token fetching happens for EACH request | ||
return Mono.fromCallable(() -> this.credentialProvider.getBearerToken(null)) | ||
.flatMap(token -> { | ||
// Create a new request with the Authorization header | ||
ClientRequest newRequest = ClientRequest.from(request) | ||
.headers(headers -> headers.setBearerAuth(token)) | ||
.build(); | ||
// Pass the new request to the next filter in the chain | ||
return next.exchange(newRequest); | ||
}); | ||
} | ||
|
||
public static String getGcpBearerAuthCustomProviderClass() { | ||
return GCP_BEARER_AUTH_CUSTOM_PROVIDER_CLASS; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this called a
class
? The implementation rather retrieves a token via custom implementation from GCP which is later used as a bearer token value, there are no "classes" in use per se.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this to reference this class. And I changed the bearer token implementation for the WebClient using this class too. Sorry 🙏 .