-
-
Notifications
You must be signed in to change notification settings - Fork 155
Adds type and schema id information to the UI for avro message keys and values #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi mbollmann-v! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
6311755
to
1de5dd2
Compare
@Haarolean Let me know if I can support in any way to bring this change into main |
3bdee59
to
8cfa5bf
Compare
@mbollmann-v Could you make the "schema id: XX" clickable to go to the schema registry tab directly ? |
Sure, I could do it in another PR once this is merged. So far I wanted to keep this one small and simple to increase the chance to get it merged at all. |
8cfa5bf
to
e0032f5
Compare
Hi @Haarolean 👋🏻 |
…nd values. Closes: kafbat#77
e0032f5
to
4a624ea
Compare
No breaking change
What changes did you make? (Give an overview)
Display the type and avro schema id when avro is used for either the key or the value of a message.
The name of the avro schema is added to the existing property map that already transfers the schema id over the rest api in the latest kafbat release (https://github.com/kafbat/kafka-ui/blob/main/contract/src/main/resources/swagger/kafbat-ui-api.yaml#L3156).
I tried to extend the UI rather non-invasive so that for non-avro messages everything stays as before and that the change is self-contained in a separate component called AvroMetadata.
For a message that uses a string key and an avro value (Avro type named "Response") the resulting UI looks like this:

Is there anything you'd like reviewers to focus on?
Let me know if you need any changes in order to be able to merge it.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
