Skip to content

Fix reading wave files generated by NAudio. #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix reading wave files generated by NAudio. #903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44bc265
Fix reading wave files generated by NAudio.
csukuangfj May 22, 2024
b21af19
add a note
csukuangfj May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sherpa-onnx/csrc/wave-reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ struct WaveHeader {
return false;
}

if (subchunk1_size != 16) { // 16 for PCM
// NAudio uses 18
// See https://github.com/naudio/NAudio/issues/1132
if (subchunk1_size != 16 && subchunk1_size != 18) { // 16 for PCM
SHERPA_ONNX_LOGE("Expected subchunk1_size 16. Given: %d\n",
subchunk1_size);
return false;
Expand Down
Loading