Skip to content

Fix a typo in the JNI for Android. #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Fix a typo in the JNI for Android. #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/android-static.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ jobs:
file_glob: true
overwrite: true
file: sherpa-onnx-*-android*.tar.bz2
# repo_name: k2-fsa/sherpa-onnx
# repo_token: ${{ secrets.UPLOAD_GH_SHERPA_ONNX_TOKEN }}
# tag: v1.11.3

build-android-aar-static:
needs: [build-android-static-libs]
Expand Down Expand Up @@ -298,3 +301,6 @@ jobs:
file_glob: true
overwrite: true
file: ./*.aar
# repo_name: k2-fsa/sherpa-onnx
# repo_token: ${{ secrets.UPLOAD_GH_SHERPA_ONNX_TOKEN }}
# tag: v1.11.3
5 changes: 4 additions & 1 deletion .github/workflows/android.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@ jobs:
file_glob: true
overwrite: true
file: sherpa-onnx-*-android.tar.bz2
# repo_name: k2-fsa/sherpa-onnx
# repo_token: ${{ secrets.UPLOAD_GH_SHERPA_ONNX_TOKEN }}
# tag: v1.11.3

build-android-aar:
needs: [build-android-libs]
Expand Down Expand Up @@ -294,7 +297,7 @@ jobs:
file: ./*.aar
# repo_name: k2-fsa/sherpa-onnx
# repo_token: ${{ secrets.UPLOAD_GH_SHERPA_ONNX_TOKEN }}
# tag: v1.11.2
# tag: v1.11.3

- name: Release android aar
if: github.repository_owner == 'k2-fsa' && github.event_name == 'push' && contains(github.ref, 'refs/tags/')
Expand Down
2 changes: 1 addition & 1 deletion sherpa-onnx/jni/offline-recognizer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ static OfflineRecognizerConfig GetOfflineConfig(JNIEnv *env, jobject config) {
jobject dolphin_config = env->GetObjectField(model_config, fid);
jclass dolphin_config_cls = env->GetObjectClass(dolphin_config);

fid = env->GetFieldID(nemo_config_cls, "model", "Ljava/lang/String;");
fid = env->GetFieldID(dolphin_config_cls, "model", "Ljava/lang/String;");

s = (jstring)env->GetObjectField(dolphin_config, fid);
p = env->GetStringUTFChars(s, nullptr);
Expand Down
Loading