Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is in reference to the issue: #1541
The current cmake logic does not handle the case where ONNX runtime is pre-installed and static linking is used.
The proposed solution modifies the
sherpa-onnx/csrc/CMakeLists.txt
file.The modified conditioning allows linking to the pre-installed ONNX Runtime when
BUILD_SHARED_LIBS
is True or whenSHERPA_ONNX_USE_PRE_INSTALLED_ONNXRUNTIME_IF_AVAILABLE
is set. This prevents build failures caused by missing onnxruntime_lib_files in static builds.Thanks