refactor: centralize V2 delete payment method endpoint #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved Delete Payment Method V2 URL from PaymentHelpersV2 to APIUtils.res - Organized endpoints under clear V1 and V2 sections in APIUtils - Replaced hardcoded references with centralized constants - Improved maintainability and consistency across API endpoints - No functional changes, all existing tests pass
Krriishhhhhh
requested review from
AbhishekChorotiya,
ArushKapoorJuspay,
aritro2002,
sakksham7 and
seekshiva
as code owners
|
Review changes with |
Contributor
|
Hey @Krriishhhhhh you have added the usage of |
Author
|
@sakksham7 i made the changes , also while running 
I am unsure whether to remove that unwanted code or not . |
Contributor
AbhishekChorotiya
left a comment
AbhishekChorotiya
left a comment
There was a problem hiding this comment.
Looking good to me!
AbhishekChorotiya
approved these changes
Oct 27, 2025
aritro2002
approved these changes
Oct 28, 2025
aritro2002
approved these changes
Oct 28, 2025
Contributor
|
Hey @Krriishhhhhh , |
Author
|
Hey @AbhishekChorotiya , thanks for the review , just wanted to ask what is the purpose of the form? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Centralizes the Delete Payment Method V2 endpoint by moving it from PaymentHelpersV2.res into APIUtils.res, improving maintainability and consistency with V1 endpoints.
Fixes juspay/hyperswitch#9317
📋 Changes Made
APIUtils.resDeletePaymentMethodV2variant toapiCallV2typepmSessionId: option<string>toapiParamstypegenerateApiUrlfunction to handle V2 update payment method pathPaymentHelpersV2.resHow did you test it?
Only build test
Checklist
npm run re:build