fix: added validation for empty clientSecret in completeUpdateIntent #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-vamshi
requested review from
AbhishekChorotiya,
ArushKapoorJuspay,
aritro2002,
sakksham7 and
seekshiva
as code owners
|
Review changes with |
s-vamshi
force-pushed
the
fix/added-validation-for-empty-client-secret-in-completeUpdateIntent
branch
2 times, most recently
from
83fc2ef to
3867c7e
Compare
Author
|
@aritro2002 can you please review now
i had to use if else block and return a resolved promise containing an empty JSON object. |
s-vamshi
force-pushed
the
fix/added-validation-for-empty-client-secret-in-completeUpdateIntent
branch
from
3867c7e to
81fcc37
Compare
Author
|
@aritro2002 can you please review this pr? |
s-vamshi
force-pushed
the
fix/added-validation-for-empty-client-secret-in-completeUpdateIntent
branch
from
81fcc37 to
03c1ae1
Compare
Author
|
@aritro2002 can you please review this pr? |
s-vamshi
force-pushed
the
fix/added-validation-for-empty-client-secret-in-completeUpdateIntent
branch
from
03c1ae1 to
e332b7b
Compare
Author
|
@aritro2002 can you please review this pr? |
Author
|
@aritro2002 can you please review this pr |
Author
|
@aritro2002 can you please review this pr? |
sakksham7
reviewed
Oct 24, 2025
s-vamshi
force-pushed
the
fix/added-validation-for-empty-client-secret-in-completeUpdateIntent
branch
from
e332b7b to
5bf700b
Compare
s-vamshi
force-pushed
the
fix/added-validation-for-empty-client-secret-in-completeUpdateIntent
branch
from
5bf700b to
e8a738c
Compare
Author
|
@sakksham7 done with suggested changes can you please review in your free time? |
aritro2002
approved these changes
Oct 28, 2025
sakksham7
approved these changes
Oct 29, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixes #9355
Added validation to check whether clientSecret is empty if its length is empty if it is then returning else continue with the existing flow
How did you test it?
Checklist
npm run re:build