feat(archipel): add authorize flow #253
Open
+1,715
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siaass842
changed the title
| request: Request, | ||
| _flow_name: &str, | ||
| ) -> CustomResult<Result<Response, Response>, ApiClientError> { | ||
| println!(">>> {:?}", request.body); |
Comment on lines
89
to
103
| /// Represents details of a payment method. | ||
| #[derive(Debug, Clone)] | ||
| pub struct PaymentMethodDetails { | ||
| /// Indicates whether mandates are supported by this payment method. | ||
| pub mandates: common_enums::FeatureStatus, | ||
| /// Indicates whether refund is supported by this payment method. | ||
| pub refunds: common_enums::FeatureStatus, | ||
| /// List of supported capture methods | ||
| pub supported_capture_methods: Vec<common_enums::CaptureMethod>, | ||
| /// Payment method specific features | ||
| pub specific_features: Option<PaymentMethodSpecificFeatures>, | ||
| } | ||
|
|
||
| /// list of payment methods, payment method types and metadata related to them | ||
| pub type SupportedPaymentMethods = HashMap<common_enums::PaymentMethod, PaymentMethodTypeMetadata>; |
Contributor
There was a problem hiding this comment.
are these changes required?
| use std::collections::HashMap; | ||
|
|
||
| use common_utils::Method; | ||
| use crate::types::{PaymentMethodSpecificFeatures, PaymentMethodTypeMetadata}; |
| Cybersource, Dlocal, Elavon, Fiserv, Fiuu, Helcim, Mifinity, Nexinets, Noon, Novalnet, Paytm, | ||
| Payu, Phonepe, Placetopay, Rapyd, Razorpay, RazorpayV2, Stripe, Trustpay, Volt, Worldpay, | ||
| Xendit, | ||
| Xendit, Archipel |
Contributor
There was a problem hiding this comment.
maintain alphabetical order here
backend/common_enums/src/enums.rs
Outdated
Comment on lines
1803
to
1815
|
|
||
| pub enum PaymentMethodStatus { | ||
| Active, | ||
| Inactive, | ||
| Processing, | ||
| AwaitingData, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub enum FeatureStatus { | ||
| NotSupported, | ||
| Supported, | ||
| } |
Comment on lines
186
to
192
| pub fn connector_base_url_refunds<'a, F, Req, Res>( | ||
| &self, | ||
| req: &'a RouterDataV2<F, RefundFlowData, Req, Res>, | ||
| ) -> &'a str { | ||
| &req.resource_common_data.connectors.archipel.base_url | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Please check if we can remove this function from here. This function should be included in refunds PR.
| // TODO: Implement proper error response parsing | ||
| Ok(ErrorResponse { | ||
| status_code: res.status_code, | ||
| code: NO_ERROR_CODE.to_string(), |
Contributor
There was a problem hiding this comment.
Check if code can be filled from the error response.
| code: NO_ERROR_CODE.to_string(), | ||
| attempt_status: None, | ||
| connector_transaction_id: None, | ||
| message: NO_ERROR_MESSAGE.to_string(), |
Contributor
There was a problem hiding this comment.
Check if message can be filled from the error response.
Anurag-05-prog
requested changes
Nov 5, 2025
| attempt_status: None, | ||
| connector_transaction_id: None, | ||
| message: NO_ERROR_MESSAGE.to_string(), | ||
| reason: None, |
Contributor
There was a problem hiding this comment.
Check if reason can be filled from the error response.
Contributor
|
Resolve Merge Conflicts. |
Contributor
|
Run |
| let capture_method = req | ||
| .request | ||
| .capture_method | ||
| .ok_or(errors::ConnectorError::CaptureMethodNotSupported)?; |
Contributor
There was a problem hiding this comment.
Use MissingRequiredField: capture_method here
| build_env_specific_endpoint(self.connector_base_url_payments(req), &req.request.metadata)?; | ||
| match capture_method { | ||
| enums::CaptureMethod::Automatic | enums::CaptureMethod::SequentialAutomatic => { | ||
| println!("here"); |
Contributor
There was a problem hiding this comment.
remove this println line
| utils::CardIssuer, | ||
| }; | ||
| use error_stack::{ report}; | ||
| // use hyperswitch_interfaces::{consts, errors}; |
Contributor
There was a problem hiding this comment.
remove this comment if it's not required
| use serde_json::Value; | ||
|
|
||
| use crate::{ | ||
| // connectors::archipel::ArchipelRouterData, |
Contributor
There was a problem hiding this comment.
remove this comment if it's not required
Comment on lines
76
to
85
| // impl TryFrom<&Option<pii::SecretSerdeValue>> for ArchipelConfigData { | ||
| // type Error = error_stack::Report<errors::ConnectorError>; | ||
| // fn try_from(connector_metadata: &Option<pii::SecretSerdeValue>) -> Result<Self, Self::Error> { | ||
| // let config_data = utils::to_connector_meta_from_secret::<Self>(connector_metadata.clone()) | ||
| // .change_context(errors::ConnectorError::InvalidConnectorConfig { | ||
| // config: "metadata. Required fields: tenant_id, platform_url", | ||
| // })?; | ||
| // Ok(config_data) | ||
| // } | ||
| // } |
Contributor
There was a problem hiding this comment.
remove this comment if it's not required
Comment on lines
95
to
106
| // fn to_connector_meta( | ||
| // connector_meta: Option<Value>, | ||
| // ) -> CustomResult<ArchipelConfigData, ConnectorError> { | ||
| // Ok(connector_meta | ||
| // .map(|meta| { | ||
| // print!("meta value {:?}",meta); | ||
| // serde_json::from_value::<ArchipelConfigData>(meta) | ||
| // .map_err(|_| report!(errors::ConnectorError::InvalidDataFormat { field_name: "metadata" })) | ||
| // }) | ||
| // .transpose()? | ||
| // .ok_or_else(|| ConnectorError::NoConnectorMetaData)?) | ||
| // } |
Contributor
There was a problem hiding this comment.
remove this comment if it's not required
| #[serde(rename_all = "camelCase")] | ||
| pub struct ArchipelOrderRequest { | ||
| amount: MinorUnit, | ||
| currency: String, |
Contributor
There was a problem hiding this comment.
Suggested change
| currency: String, | |
| currency: enums::Currency, |
| + Serialize, | ||
| > { | ||
| card_data: ArchipelTokenizedCard<T>, | ||
| // wallet_information: ArchipelWalletInformation, |
| AttemptStatus::AuthenticationFailed => Ok(Self::Verify), | ||
| AttemptStatus::Authorizing | ||
| | AttemptStatus::Authorized | ||
| | AttemptStatus::AuthorizationFailed => Ok(Self::Authorize), |
Contributor
There was a problem hiding this comment.
Why AuthorizationFailed is mapped with Authorize?
Comment on lines
505
to
508
| amount: Option<i64>, | ||
| currency: Option<Currency>, | ||
| captured_amount: Option<i64>, | ||
| authorized_amount: Option<i64>, |
Contributor
There was a problem hiding this comment.
Use MinorUnit instead of i64.
| .router_data | ||
| .request | ||
| .capture_method | ||
| .ok_or_else(|| errors::ConnectorError::CaptureMethodNotSupported)?; |
Contributor
There was a problem hiding this comment.
use MissingRequiredField: capture_method here.
Comment on lines
402
to
404
| AttemptStatus::Authorizing | ||
| | AttemptStatus::Authorized | ||
| | AttemptStatus::AuthorizationFailed => Ok(Self::Authorize), | ||
| | AttemptStatus::AuthorizationFailed => Ok(Self::Cancel), |
Contributor
There was a problem hiding this comment.
check this status mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added CA certificate support for API calls in the Archipel connector, following the pattern from hyperswitch PR #8128. This enables one-way TLS
authentication with custom CA certificates for the Archipel connector.
Changes made:
ConnectorIntegrationV2 Trait (
backend/interfaces/src/connector_integration_v2.rs)get_ca_certificate()method to the trait interfacebuild_request_v2()to call.add_ca_certificate_pem()Archipel Connector (
backend/connector-integration/src/connectors/archipel.rs)get_ca_cert()helper function to extract CA certificate from authget_ca_certificate()method to return the CA certificate from auth detailsHTTP Client (
backend/external-services/src/service.rs)create_client()function to support three modes:Archipel Auth Type (already existed in
transformers.rs)ca_certificatefield inArchipelAuthTypeConnectorAuthType::HeaderKey { api_key }Motivation and Context
The Archipel connector requires custom CA certificate support for secure communication with their API endpoints. This allows the connector to authenticate the server using a custom CA certificate, which
is essential for environments with self-signed or internal CA certificates.
This implementation follows the established pattern from the hyperswitch repository to maintain consistency across the codebase.
Type of Change
Additional Changes
How did you test it?
cargo build --workspaceManual Testing Required:
To fully test this feature, the following steps should be performed:
HeaderKeyauth typeFiles Modified:
backend/interfaces/src/connector_integration_v2.rs:211-220- Addedget_ca_certificate()methodbackend/interfaces/src/connector_integration_v2.rs:108- Added.add_ca_certificate_pem()callbackend/connector-integration/src/connectors/archipel.rs:34- AddedSecretimportbackend/connector-integration/src/connectors/archipel.rs:168-177- Addedget_ca_cert()helperbackend/connector-integration/src/connectors/archipel.rs:779-784- Overrodeget_ca_certificate()backend/external-services/src/service.rs:741-788- Implemented CA cert support in HTTP client