-
Notifications
You must be signed in to change notification settings - Fork 7
feat(connector): [CELEROCOMMERCE] Connector Integration #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0938171 to
008d357
Compare
| #[serde(rename = "type")] | ||
| pub transaction_type: CeleroTransactionType, | ||
| pub amount: MinorUnit, | ||
| pub currency: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use enum currency
| ..item.router_data | ||
| }); | ||
| } | ||
| CeleroCardStatus::Refunded => AttemptStatus::Charged, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Refunded marked as charged?
| pub struct CeleroBillingAddressResponse { | ||
| pub first_name: Option<String>, | ||
| pub last_name: Option<String>, | ||
| pub company: Option<String>, | ||
| pub address_line_1: Option<String>, | ||
| pub address_line_2: Option<String>, | ||
| pub city: Option<String>, | ||
| pub state: Option<String>, | ||
| pub postal_code: Option<String>, | ||
| pub country: Option<String>, | ||
| pub phone: Option<String>, | ||
| pub fax: Option<String>, | ||
| pub email: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make pii fields secret and use struct Email for email
| impl TryFrom<&RouterDataV2<PSync, PaymentFlowData, PaymentsSyncData, PaymentsResponseData>> | ||
| for CeleroSyncRequest | ||
| { | ||
| type Error = error_stack::Report<errors::ConnectorError>; | ||
|
|
||
| fn try_from( | ||
| _item: &RouterDataV2<PSync, PaymentFlowData, PaymentsSyncData, PaymentsResponseData>, | ||
| ) -> Result<Self, Self::Error> { | ||
| // Empty request for GET-based sync - transaction ID is passed in URL | ||
| Ok(Self {}) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed
| // Capture response structure (uses same format as payment response) | ||
| #[derive(Debug, Deserialize, Serialize)] | ||
| pub struct CeleroCaptureResponse { | ||
| pub status: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is status string?
Description
CeleroCommerce Connector Integration
Flows implemented
Auth (Manual , Automatic) , Capture ,Psync ,Rsync , Void ,Refund
Motivation and Context
Additional Changes
How did you test it?
Tested using GRPCurls using the mockserver of CeleroCommerce in hyperswitch
Auth
RequestResponse
Capture
RequestResponse
Refund
Request
Response
Void
RequestResponse