fix: reduce parallelism in default config creation and improved logging #134
+192
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGeorg
reviewed
Oct 8, 2025
| res.headers_mut().insert( | ||
| actix_web::http::header::HeaderName::from_static("x-request-id"), | ||
| rid.parse().unwrap(), | ||
| HeaderName::from_static("x-req-id"), |
Contributor
Author
There was a problem hiding this comment.
Changed it back to x-request-id
Collaborator
|
@yuvrajjsingh0 why does this need a lot of changes? Making code from parallel to sequential should usually be a lot simpler |
JamesGeorg
reviewed
Oct 8, 2025
| { | ||
| let n = operations.len(); | ||
| let mut set = JoinSet::new(); | ||
| assert!(n >= 1, "need at least one operation (the final)"); |
Collaborator
There was a problem hiding this comment.
Where is this assert handled?
Contributor
Author
There was a problem hiding this comment.
Removed it, added safe if..else to handle these
| App::new() | ||
| .wrap(actix_web::middleware::from_fn(request_id_mw)) | ||
| .wrap(TracingLogger::default()) | ||
| .wrap(TracingLogger::<WithRequestId>::new()) |
Collaborator
There was a problem hiding this comment.
Does this PR have other changes, Or is this needed to sequentialise
Contributor
Author
There was a problem hiding this comment.
It has changes for request_id other than sequentialise
yuvrajjsingh0
force-pushed
the
make-default-config-creation-serial
branch
from
568a5e0 to
92a6bee
Compare
Yash02Rajput
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce parallelism so that superposition doesn't get into race conditions - if I have N operations to do, I'do N-1 operations concurrently and wait for them to complete, then do the last operation, this way superposition's last config snapshot creation will always have latest data and won't run through race conditions.
[Logging]
Added more contexts in the default span: