Skip to content

Fix branch creation for empty clone #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

Fix branch creation for empty clone #1411

merged 5 commits into from
Jun 12, 2025

Conversation

gjmooney
Copy link
Contributor

Fix #1406. This was pretty much the same issue as #1363.

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a Binder on branch gjmooney/jupyterlab-git/fix_branch_creation_for_empty_clone

@krassowski krassowski added the bug label Jun 11, 2025
@jtpio
Copy link
Member

jtpio commented Jun 11, 2025

Thanks @gjmooney for working on this!

Hopefully #1412 will fix the failing CI check.

Would you be able to share a quick screencast? Just so our future selves can look back at the PR and remember this was fixed at some point :)

krassowski
krassowski reviewed Jun 11, 2025
View reviewed changes
gjmooney and others added 2 commits June 12, 2025 10:35
@gjmooney @krassowski
Use snake case for consistency
7cbe4dd 
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@gjmooney
Merge branch 'main' into fix_branch_creation_for_empty_clone
b8422ae
@gjmooney
Copy link
Contributor Author

Would you be able to share a quick screencast? Just so our future selves can look back at the PR and remember this was fixed at some point :)

emptybranch

jtpio
jtpio approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 22b5174 into jupyterlab:main Jun 12, 2025
8 checks passed
@gjmooney gjmooney deleted the fix_branch_creation_for_empty_clone branch June 12, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski left review comments

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new branch after closing an empty repository fails
3 participants
@gjmooney @jtpio @krassowski