Skip to content

Jupyter chat package reorganization #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jun 6, 2025

This PR is a reorganization of the @jupyter-chat package, it is only maintenance.
There should be no breaking change and no changes in the UI.

The main changes are:

  • split of the chat-messages module into several modules in components/messages (e.g. footer.tsx, header.tsx, message.tsx, navigation.tsx...)
  • centralize all the registers in a dedicated directory: attachment-openers, chat-commands and footers

Fixes #219

@brichet brichet marked this pull request as draft June 6, 2025 11:54
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/jupyter-chat-package-reorganization

@brichet brichet added the maintenance Packaging, tests label Jun 6, 2025
@brichet brichet marked this pull request as ready for review June 6, 2025 12:24
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@brichet brichet force-pushed the jupyter-chat-package-reorganization branch from 30290be to 1db09c1 Compare June 12, 2025 07:40
@brichet brichet merged commit 9199cbc into jupyterlab:main Jun 12, 2025
12 checks passed
@brichet brichet deleted the jupyter-chat-package-reorganization branch June 12, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Packaging, tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the chat module into several modules
2 participants