Move runtime.txt
parsing into base class
#1428
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a discussion somewhere (I can't remember where) about using https://github.com/astrofrog/pypi-timemachine or similar so Python packages can be installed as if
pip
were run in the past, similar to R. If we do this we should define the cutoff date for Python in the same way as for R, which is to useruntime.txt
.Something to consider is we haven't formally defined what
runtime.txt
contains.Our docs state it should be one of:
name-version-yyyy-mm-dd
: (r-<RVERSION>-<YYYY>-<MM>-<DD>
)name-version
: (python-x.y
)repo2docker/docs/source/config_files.rst
Lines 201 to 207 in e795060
Our tests say it can also be:
repo2docker/tests/unit/test_r.py
Line 38 in e795060
This PR handles all three formats. I've made a breaking change and redefined the existing
.runtime
property instead of creating a new one to avoid leaving an unused.runtime
property that may cause confusion in the future.