Skip to content

update postBuild tests without ipyleaflet #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2024
Merged

update postBuild tests without ipyleaflet #1348

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
617a951
tests: pin ipyleaflet<0.19 to get tests passing
manics May 26, 2024
857dd9f
Remove jupyter nbextension enable --py --sys-prefix ipyleaflet
manics May 27, 2024
d0ef082
binder-dir: use postBuild that can be verified
manics May 27, 2024
5798f45
verify that postBuild is run in tests/venv/start/postBuild
minrk May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/venv/binder-dir/binder/postBuild
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/bash
jupyter nbextension enable --py --sys-prefix ipyleaflet
echo 'Done!' > $HOME/postbuild.txt
2 changes: 2 additions & 0 deletions tests/venv/binder-dir/verify
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ which gfortran
test -z $(pip list | grep scipy)
jupyter nbextension list
jupyter nbextension list | grep 'jupyter-leaflet' | grep enabled

grep 'Done!' $HOME/postbuild.txt
2 changes: 0 additions & 2 deletions tests/venv/start/postBuild/postBuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,3 @@

# this value should not be visible in `verify`
export TEST_START_VAR="var is set by postBuild"

jupyter nbextension enable --py --sys-prefix ipyleaflet
Loading