Add the terminal #63
Add the terminal #63
Conversation
|
|
|
cc @ianthomas23 it's looking good on ReadTheDocs, and with vim! https://try-jupyter--63.org.readthedocs.build/en/63/lite/lab/index.html
|
build-environment.yml
Outdated
| @@ -4,6 +4,8 @@ channels: | |||
| dependencies: | |||
| - python =3.12 | |||
| - mamba | |||
| - micromamba =2.0.5 | |||
| - nodejs =22 | |||
There was a problem hiding this comment.
It would be great to not have to depend on nodejs as a user of jupyterlite-terminal.
But this can likely be tracked in https://github.com/jupyterlite/terminal or https://github.com/jupyterlite/cockle.
build-environment.yml
Outdated
| - jupyterlite-xeus>=4.0.0 | ||
| - notebook >=7.4.3,<7.5 | ||
| - pip | ||
| - plotly >=6,<7 | ||
| # micromamba and nodejs are needed for jupyterlite-terminal | ||
| - micromamba =2.0.5 |
There was a problem hiding this comment.
I've been using micromamba 2.1 locally without any problems, so maybe remove the pin and see if that works here.
There was a problem hiding this comment.
@martinRenou mentioned something about newer releases causing some issues? jupyterlite/xeus#248
There was a problem hiding this comment.
I wasn't able to reproduce micromamba >2.0.5 issues on all build setups. e.g. the jupyterlite-xeus deployment on readthedocs is always failing, but other deployments like the one of jupytergis works just fine.
Anyway, micromamba is being pinned by the jupyterlite-xeus package on conda-forge, so if you install it from conda-forge you don't need to pin anything.
There was a problem hiding this comment.
ok, happy to relax the pin then if there is no issue anymore. Maybe still keeping an upper bound on <3 just in case.
There was a problem hiding this comment.
I'd let jupyterlite-xeus manage its dependency though, so I'd suggest simply removing this
There was a problem hiding this comment.
But here jupyterlite-terminal also requires micromamba, and jupyterlite-terminal on conda forge currently does not depend on it even though it's used in https://github.com/jupyterlite/cockle/blob/a6debb757c8f232e4d260eab37d7aa0db2d28f1d/src/tools/prepare_wasm.ts#L121.
So I guess it makes sense to add the dependency here to avoid using the implicit dependency from jupyterlite-xeus?
There was a problem hiding this comment.
Ah got it! I missed this information
|
Thanks @ianthomas23 and @martinRenou for the reviews! Looks like it would already be useful to have the terminal in its current state, so happy to merge! |
To have a terminal on the demo deployment for Jupyter, using https://github.com/jupyterlite/terminal