Skip to content

Revert "breaking: require Python 3.9" #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.9", "3.12", "3.13"]
python-version: ["3.8", "3.12", "3.13"]
include:
- os: windows-latest
python-version: "3.9"
- os: ubuntu-latest
python-version: "3.11"
- os: ubuntu-latest
Expand Down
3 changes: 1 addition & 2 deletions jupyter_core/paths.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@
import sys
import tempfile
import warnings
from collections.abc import Iterator
from contextlib import contextmanager
from pathlib import Path
from typing import Any, Literal, Optional, overload
from typing import Any, Iterator, Literal, Optional, overload

import platformdirs

Expand Down
3 changes: 1 addition & 2 deletions jupyter_core/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@
import sys
import threading
import warnings
from collections.abc import Awaitable
from contextvars import ContextVar
from pathlib import Path
from types import FrameType
from typing import Any, Callable, TypeVar, cast
from typing import Any, Awaitable, Callable, TypeVar, cast


def ensure_dir_exists(path: str | Path, mode: int = 0o777) -> None:
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ classifiers = [
"Programming Language :: Python",
"Programming Language :: Python :: 3"
]
requires-python = ">=3.9"
requires-python = ">=3.8"
dependencies = [
"platformdirs>=2.5",
"traitlets>=5.3",
Expand Down Expand Up @@ -102,7 +102,7 @@ build = [

[tool.mypy]
files = "jupyter_core"
python_version = "3.9"
python_version = "3.8"
strict = true
enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
warn_unreachable = true
Expand Down
5 changes: 2 additions & 3 deletions tests/test_migrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,8 @@ def notice_m_dir(src, dst):
called["migrate_dir"] = True
return migrate_dir(src, dst)

with (
patch.object(migrate_mod, "migrate_file", notice_m_file),
patch.object(migrate_mod, "migrate_dir", notice_m_dir),
with patch.object(migrate_mod, "migrate_file", notice_m_file), patch.object(
migrate_mod, "migrate_dir", notice_m_dir
):
assert migrate_one(src, dst)
assert called == {"migrate_file": True}
Expand Down
Loading