Skip to content

Use proper BASE_IMAGE in contributed recipes for forks #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 13, 2025

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

What happened:

  1. I pinned libxml2 in both jupyter/docker-stacks and my fork (almost simultaneously).
  2. My fork started running docker.yml workflow, which then runs contributed-recipes.yml workflow
  3. Instead of using fork built images, contributed recipes in my fork used images pushed to the jupyter registry (images with libxml2 pin were not yet pushed, so previous images were used)
  4. I got a failure: https://github.com/mathbunnyru/docker-stacks/actions/runs/14419023194/job/40439441899

--rm --force-rm \
--tag my-custom-image \
-f ./${{ matrix.dockerfile }} \
--build-arg BASE_IMAGE=${{ env.REGISTRY }}/${{ env.OWNER }}/${{ matrix.parent-image }} \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's possible to write a ternary here, but if someone knows how do it, it would be great

@mathbunnyru mathbunnyru merged commit 0ab0a2f into jupyter:main Apr 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant