Skip to content

Add timeouts to all GitHub jobs #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

I recently had a timeout issue in my fork: https://github.com/mathbunnyru/docker-stacks/actions/runs/13424787928/job/37505995405

And we actually hit 6h timeout many times when building aarch64 images on self-hosted runners.

So, let's add GitHub timeouts, to fail fast.
These are not super strict and I would rather give a few extra minutes for a job to finish than get a build failure.
And we might want to increase some of these in the future.

Comment on lines +18 to +21
timeout-minutes:
description: Timeout in minutes
type: number
default: 25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably be better set as a param for each image, but for now let's keep one common timeout (the same goes for docker-tag-push.yml)

@mathbunnyru mathbunnyru merged commit 3d9ce7c into jupyter:main Feb 20, 2025
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant