Skip to content

Now opens editor and viewer #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 42 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,17 @@ const extension: JupyterFrontEndPlugin<void> = {
languageRegistry: IEditorLanguageRegistry
) => {
console.log('JupyterLab extension URDF is activated!');
const { commands } = app;
const { commands, shell } = app;

// Tracker
const namespace = 'jupyterlab-urdf';
const tracker = new WidgetTracker<URDFWidget>({ namespace });

// Track split state
let splitDone = false;
let leftEditorRefId: string | null = null;
let rightViewerRefId: string | null = null;

// State restoration: reopen document if it was open previously
if (restorer) {
restorer.restore(tracker, {
Expand All @@ -89,7 +94,7 @@ const extension: JupyterFrontEndPlugin<void> = {
});

// Add widget to tracker when created
widgetFactory.widgetCreated.connect((sender, widget) => {
widgetFactory.widgetCreated.connect(async (sender, widget) => {
widget.title.icon = urdf_icon;
widget.title.iconClass = 'jp-URDFIcon';

Expand All @@ -98,6 +103,41 @@ const extension: JupyterFrontEndPlugin<void> = {
tracker.save(widget);
});
tracker.add(widget);

// Reset split state when all widgets are closed
widget.disposed.connect(() => {
if (tracker.size === 0) {
splitDone = false;
leftEditorRefId = null;
rightViewerRefId = null;
}
});

// Split layout on first open, then tab into panels
if (!splitDone) {
const editor = await commands.execute('docmanager:open', {
path: widget.context.path,
factory: 'Editor',
options: { mode: 'split-left', ref: widget.id }
});
splitDone = true;
leftEditorRefId = editor.id;
rightViewerRefId = widget.id;
} else {
if (rightViewerRefId) {
shell.add(widget, 'main', {
mode: 'tab-after',
ref: rightViewerRefId
});
}
if (leftEditorRefId) {
await commands.execute('docmanager:open', {
path: widget.context.path,
factory: 'Editor',
options: { mode: 'tab-after', ref: leftEditorRefId }
});
}
}
});

// Register widget and model factories
Expand Down
Loading