-
Notifications
You must be signed in to change notification settings - Fork 11
Issue controls panel UI #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue controls panel UI #81
Conversation
7403b2d
to
2246948
Compare
Resolves #57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


This is going in the right direction, but it could be better. At the moment, when the panel is resized, all 3 columns (joint names, sliders, and input boxes) stretch. We should keep the width of the sliders and input boxes fixed so that the joint names can occupy the newly created space when resizing the gui.
The control panel now resizes as requested: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resizing seems to be working well, however, long joint names are still being truncated and there's leftover space that is not being used.
To fix this, this div could be turned into a flex container.
<li class="cr number has-slider">
<div>...</div>
</li>
Then the style of the property-name
can be changed so that it can grow and not shrink and keep the default width of 40%. Then also setting the overflow to scroll
instead of hidden
for those extra long joint names.
The resizing functionality is good, but for future reference, it might be worth looking into Resize Observers.
I made some CSS changes to fix the overflow for the joint names by making the div that contains the control row into a flex container and tweaking some parameters. |
I merged the changes from main to resolve the conflict that existed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thanks!
Made the controls panel resizable to manly fix the issue of joint names being too long to read:
-Added the pseudo element .urdf-gui::before in base.css for the invisible handle.
-Added a min and max width for the panel.
-Overwritten style for the "close controls" button to fix some issues.
-Added a function _setupResizeHandling in controls.ts to implement this.