Implement starting values for NormOneBridge #994
Conversation
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 95.26% 95.26% -0.01%
==========================================
Files 97 97
Lines 10803 10823 +20
==========================================
+ Hits 10291 10310 +19
- Misses 512 513 +1
Continue to review full report at Codecov.
|
| @@ -100,13 +100,17 @@ end | |||
| MOIT.normone1vtest(bridged_mock, config) | |||
There was a problem hiding this comment.
just a question: what's the point of running this test set here? it's not relevant to all the below tests right? I ask because in #976 I have multiple test sets but currently only run one of them in the bridge test file
There was a problem hiding this comment.
It does not affect tests below but it still adds coverage. normone1f uses VAF functions and normone1v uses VOV. So this tests that the bridging and the getters of ConstraintPrimal and ConstrainDual work when the input function is VOV
There was a problem hiding this comment.
OK I didn't realize it wasn't called elsewhere. I'll add both tests for spectral and for nuclear cones then.
There was a problem hiding this comment.
wait no I misunderstood. it only works for the same test modulo the vov/vaf difference. so scrap what I said.
There was a problem hiding this comment.
Yes, so in your case you'll have to redo the mock dual and primal values so probably not worth it
See #684