Skip to content

Add PSD3 test #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Add PSD3 test #1007

merged 1 commit into from
Jan 21, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 21, 2020

Add PSD test with offdiagonal constant. This would have caught the bug fixed by jump-dev/SCS.jl#171

@codecov-io
Copy link

Codecov Report

Merging #1007 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   95.19%   95.21%   +0.01%     
==========================================
  Files          99       99              
  Lines       11166    11308     +142     
==========================================
+ Hits        10630    10767     +137     
- Misses        536      541       +5
Impacted Files Coverage Δ
src/Test/contconic.jl 99.26% <100%> (+0.01%) ⬆️
src/sets.jl 95.65% <0%> (-0.94%) ⬇️
src/FileFormats/LP/LP.jl 97.95% <0%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49180c6...0e9f7e8. Read the comment docs.

@blegat blegat added this to the v0.9.10 milestone Jan 21, 2020
@blegat blegat merged commit 823ffc6 into master Jan 21, 2020
@odow odow deleted the bl/psd3 branch February 20, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants