Skip to content

Support SQLAlchemy 2.0 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Support SQLAlchemy 2.0 #91

wants to merge 22 commits into from

Conversation

phillipuniverse
Copy link

Fixes #83.

I lost write access and cannot make further updates to the PR at #84, so opening this against my personal account.

javimudi and others added 22 commits January 9, 2024 09:30
@javimudi @phillipuniverse
fix(models): Check for None entity when getting query models
220d092 
Under some circunstances, such as prepping an aliased subquery to be joined later on, the model entity is missing,
provoking an error when trying to apply filters.

(cherry picked from commit edc7c24)
@bodik @phillipuniverse
sqlalchemy 1.4 infer tables also from select object (sqlalchemy 2.0 s…
66e3941 
…tyle?)

(cherry picked from commit b6791e3)
@bodik @phillipuniverse
sqlalchemy 1.4 infer tables also from select object (fix auto_join)
7e0854a 
(cherry picked from commit 203d401)
@phillipuniverse
Conditional access of _legacy_setup_joins property
c94c862 
This property is removed in SQLAlchemy 2.x
@phillipuniverse
Gitignore venv and local dev tool directories
db58232
@phillipuniverse
Tox with SQLAlchemy 2
407f7c3
@phillipuniverse
Add all compatible Python versions to .python-version and remove from…
dc7786e 
… .gitignore

This allows Tox to find all Python versions when using pyenv
@phillipuniverse
Move tox to default dev dependencies
b45a30c
@phillipuniverse
SQLAlchemy 2 compatibility with drop_all
7fcb4c1 
drop_all() makes the 'bind' positional argument required
@phillipuniverse
Avoid building wheels on later Python versions with mysql and postgre…
a951949 
…s drivers
@phillipuniverse
Configure Tox for SQLAlchemy 2 and Python 3.11, 3.12
389b17c 
Specify compatible versions of SQLAlchemy and SQLAlchemy-Utils for Python, SQLAlchemy versions
@phillipuniverse
SQLAlchemy 2 compatibility for hybrid properties and methods
debf911
@phillipuniverse
Move all Tox env configuration and version compatibility into tox.ini
a0dea62
@phillipuniverse
Fix tox expression for sqlalchemy-utils dep
d7d2246
@phillipuniverse
SQLAlchemy 2 swapped order of columns in SELECT statement
526375f
@phillipuniverse
Use tox version from setup.py
39f54fc
@phillipuniverse
Use Tox 3-compatible version of tox-gh-actions
bcd4848
@phillipuniverse
Fix flake8
73bed5e
@phillipuniverse
Add Python 3.11 and 3.12 to CI
9fd5f99
@phillipuniverse
Minimum SQLAlchemy-Utils 0.38.3
1865f0d 
Simplifies tox expressions and doesn't change anything fundamental about this library. 0.38.3 dropped support for Python 3.4 and 3.5 which sqlalchemy-filters never supported in the first place
@phillipuniverse
Merge branch 'master' into sqlalchemy-2.x
bef9e82
@phillipuniverse
Uncomment tests, first attempt at adding entities for SA 2
402e27d
@phillipuniverse phillipuniverse mentioned this pull request Feb 26, 2025
Closed
@henrikmathisen
Copy link

henrikmathisen commented Feb 26, 2025 •
edited
Loading 

Error: ERROR:   py311-sqlalchemy1.2: could not install deps [sqlalchemy-utils>=0.39, sqlalchemy>=1.2,<1.3]; v = InvocationError("/home/runner/work/sqlalchemy-filters/sqlalchemy-filters/.tox/py311-sqlalchemy1.2/bin/python -m pip install 'sqlalchemy-utils>=0.39' 'sqlalchemy>=1.2,<1.3'", 1)
Error: ERROR:   py311-sqlalchemy1.3: commands failed
Error: ERROR:   py311-sqlalchemy1.4: commands failed

Maintaining backwards compatibility with <2.0 seems unwise and maintaining backwards compatibility with <1.4 pure madness.

Dreamsorcerer
Dreamsorcerer reviewed May 8, 2025
View reviewed changes
.gitignore
Comment on lines +13 to +17

venv
.venv
.idea
build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

@Dreamsorcerer
Copy link 

Error: ERROR:   py311-sqlalchemy1.2: could not install deps [sqlalchemy-utils>=0.39, sqlalchemy>=1.2,<1.3]; v = InvocationError("/home/runner/work/sqlalchemy-filters/sqlalchemy-filters/.tox/py311-sqlalchemy1.2/bin/python -m pip install 'sqlalchemy-utils>=0.39' 'sqlalchemy>=1.2,<1.3'", 1)
Error: ERROR:   py311-sqlalchemy1.3: commands failed
Error: ERROR:   py311-sqlalchemy1.4: commands failed

Maintaining backwards compatibility with <2.0 seems unwise and maintaining backwards compatibility with <1.4 pure madness.

I would have to agree with that. Users are not going to get any updates (security or otherwise) for sqlalchemy if they are on those old versions, so why should they expect to get updates for sqlalchemy-filters? If they want to use an unsupported version of sqlalchemy, then they can also use an unsupported version of sqlalchemy-filters...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SQLAlchemy 2.X
5 participants
@phillipuniverse @henrikmathisen @Dreamsorcerer @javimudi @bodik