prevent duplicating newlines in ERB outupt. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arBmind
commented
Aug 28, 2017
arBmind
commented
- it destroys preformatted text
* it destroys preformatted text
|
are there any tests for this? |
|
I ran into this with our modified version of comfortable-mexican-sofa. There is only one test for the ERB generator. I have now added a unit test. I think it would be wise to add an integration test. But the ERB parser right now, does not generate any newline expressions. SLIM generates a lot of them. It seems there are not many use cases for the ERB generator. But if this feature is here, it should work properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.