Various cleanups #85
Merged
Various cleanups #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in 290239a.
Use `$value` instead of `$data->$name` everywhere. Makes the code slightly easier to read. There is slight change in behaviour: if the data does not have the `Sportident` or `Country` field, it will be skipped, whereas, previously, it would have been listed as “to rent” or “unknown”, respectively. But this could only occur when the configuration changed to add those fields after a team had already been registered so we do not really care.
Following nette/web-project@9dc365a `secret` represents a secret key that should be set to `nette-debug` cookie to enable the development mode, in addition to the IP requirement: https://doc.nette.org/en/application/bootstrapping#toc-development-vs-production-mode
They look like setters but the object is actually immutable.
Having private members with the same name is quite confusing. Also the properties are readonly so we should have been using `@property-read`.
Inspired by nette/web-project@38496dc
Based on nette/web-project@14b830f Also include comments from nette/web-project@c354140
The layout template already includes the title in the body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial modernization based on https://github.com/nette/web-project