Generate QR code for quick payment #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced `accountNumber` field in 254d94d. Later, in 62ecc0b, we started picking it up from `$parameters['entries']`. This carried over to the `Entries` configuration model in 290239a. However, the documentation actually suggests it belongs directly to `parameters`, which makes more sense IMO. Let’s move it to `Parameters`.
- Validate account number to prevent potential typos. - Store it as IBAN, to be potentially used in e-mail templates for foreign competitors (`$accountNumberIban` variable). - The original string is still kept for more familiar experience for Czech bank account holders.
IIRC, it is needed for currency handling in Money.
This should make payments much more convenient for mobile-first crowd. Currently, this is only supported in the initial mail, not in `CommunicationPresenter`. I manually verified a generated SPD string using https://qr-platba.cz/pro-vyvojare/validator/ This introduces a mandatory `gd` dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make payments much more convenient for mobile-first crowd.
Currently, this is only supported in the initial mail, not in
CommunicationPresenter.I manually verified a generated SPD string using https://qr-platba.cz/pro-vyvojare/validator/