Skip to content

[Docs] edited the link to the badge last commit #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Olexandr88
Copy link

No description provided.

@ljharb
Copy link
Member

ljharb commented Jun 12, 2025

why? this will be a strictly less useful view.

@Olexandr88
Copy link
Author

why? this will be a strictly less useful view.
In my opinion, this new link is completely consistent with this badge.

Знімок екрана 2025-06-12 о 19 00 01 I can even give an example of projects using this very link.

@ljharb
Copy link
Member

ljharb commented Jun 12, 2025

I'm sure people do link to it, but a link to the last commit is already always visible above the file view, above the readme, so it's redundant, and those projects shouldn't be using it :-)

the pulse link also lists multiple recent commits, which makes it more useful

@Olexandr88
Copy link
Author

thank you for the clarification, you convinced me that your point of view has the right to life

@Olexandr88
Copy link
Author

I still have a question for you regarding this badge.

Знімок екрана 2025-06-12 о 19 18 51

I suggest replacing it with another one, for example this one. What do you think?

https://github.com/jsx-eslint/eslint-plugin-react/actions/workflows/github-code-scanning/codeql/badge.svg

@ljharb
Copy link
Member

ljharb commented Jun 12, 2025

The issue with that badge isn't the image, it's that runkit is down. codeql status isn't interesting, but certainly if you have another free alternative to display a badge for the status of all github actions on a branch, that'd be great.

@Olexandr88
Copy link
Author

can suggest this one
https://img.shields.io/badge/build-passing-green.svg

@ljharb
Copy link
Member

ljharb commented Jun 12, 2025

Again, I don't need an image suggestion - i need a service that can report the status, which is what runkit is doing when it's not down.

@Olexandr88
Copy link
Author

@ljharb
Copy link
Member

ljharb commented Jun 15, 2025

Right. I think you're fundamentally not understanding the scope of the problem here :-)

The badge image is perfect. GitHub's built-in status reporting is wildly insufficient. What's required is an external service, that's free, that can summarize the status of every status check assigned to a given branch head. It's not a trivial fix and in the absence of a complete fix, doing anything is always worse than doing nothing.

@Olexandr88
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants