Skip to content

remove polyfills #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

remove polyfills #1020

merged 4 commits into from
Oct 25, 2024

Conversation

talentlessguy
Copy link
Contributor

@talentlessguy talentlessguy commented Oct 20, 2024 •
edited by ljharb
Loading

TODO:

  • array-includes
  • array.prototype.flatmap
  • object.fromentries
  • string.prototype.includes
  • hasown

this PR also bumps minimum Node version to 18 and ESLint to 8 (both in GHA and package.json)

@talentlessguy talentlessguy changed the title [Deps] Remove polyfills [Deps] Remove polyfills and prepare for the next breaking change Oct 21, 2024
@talentlessguy talentlessguy marked this pull request as ready for review October 21, 2024 01:05
@ljharb ljharb changed the base branch from main to breaking October 21, 2024 23:35
@ljharb
Copy link
Member

ljharb commented Oct 21, 2024

I pushed up my in-progress breaking branch, and rebased this PR on top of it.

@ljharb ljharb changed the title [Deps] Remove polyfills and prepare for the next breaking change remove polyfills Oct 21, 2024
ljharb
ljharb approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb
Copy link
Member

ljharb commented Oct 21, 2024

(don't worry about the test failures; i think they're coming from the breaking branch. i'll rebase this and merge it into the breaking branch once things are passing)

MichaelDeBoey
MichaelDeBoey suggested changes Oct 25, 2024
View reviewed changes
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 25, 2024
Merged
@ljharb ljharb force-pushed the breaking branch 3 times, most recently from 332fecc to 9dd2253 Compare October 25, 2024 03:30
ljharb
ljharb approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased, and will merge into the breaking branch. thanks!

talentlessguy and others added 2 commits October 25, 2024 16:03
@talentlessguy @MichaelDeBoey @ljharb
[Refactor] avoid spreading things that are already arrays
0298c54 
Co-authored-by: v1rtl <hi@v1rtl.site>
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@talentlessguy @ljharb
[flow] update flow so there are no errors
9ff0f5f
@socket-security Socket Security
Copy link

socket-security bot commented Oct 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/flow-bin@0.250.0 None 0 168 MB flowtype

🚮 Removed packages: npm/flow-bin@0.147.0

View full report↗︎

MichaelDeBoey
MichaelDeBoey suggested changes Oct 25, 2024
View reviewed changes
@talentlessguy
Copy link
Contributor Author

@ljharb @MichaelDeBoey CI is green now, safe to merge?

@ljharb ljharb merged commit 9ff0f5f into jsx-eslint:breaking Oct 25, 2024
24 checks passed
@talentlessguy talentlessguy deleted the remove-polyfills branch October 26, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talentlessguy @ljharb @MichaelDeBoey